-
Notifications
You must be signed in to change notification settings - Fork 987
Add support for zsh #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zsh #469
Conversation
|
I'm also very new to zsh, but couldn't seem to get this to work; am I doing something incorrectly? Here's the excerpt from my where |
|
Because bash-git-prompt sets $PROMPT_COMMAND which is specific to bash only, you need to add the following to get the prompt to take effect in zsh: |
|
Thanks, I was able to get it displaying, and have submitted a pull request into your fork to correct a few issues I found. In addition, one remaining issue that I'm seeing is that my prompt doesn't expand The root cause of this is the escaped |
|
@magicmonty or @ogr3 do you know if it's safe to just leave |
- Use added `NewLine` variable for zsh-specific newline - `Time12a` variant added for zsh
Correct issues with default theme on zsh
|
I'm also interested in this feature! I've checked out your branch and works like a charm adding @MPLew-is snippet and |
|
what's the purpose of this PR? i think this project is a port for bash of https://github.com/olivierverdier/zsh-git-prompt , which provides support for customizing the zsh prompt for git. can you use that instead? |
|
@geksiong Could you please rebase to the latest master and ensure again, that bash is unaffected? |
|
@guenhter I haven't heard from geksiong in a few years (see geksiong#2), so I've put up a new PR in #525 that is rebased against the current |
|
Implemented via #525 |
This is my attempt to make bash-git-prompt work with zsh, by modifying the bash scripts without introducing additional scripts. It assumes the zsh colors module is loaded.
Disclaimer: I'm new to zsh scripting as I recently switched to zsh. It seems to work fine on my system so far, but may need more testing.
ps. It still works with bash